Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Перенос Drones & SpaceSEC #200

Merged
merged 35 commits into from
Aug 17, 2024
Merged

Conversation

Lonkuk
Copy link
Contributor

@Lonkuk Lonkuk commented Aug 7, 2024

Проверки

  • PR полностью завершён и мне не нужна помощь чтобы его закончить.
  • Я внимательно просмотрел все свои изменения и багов в них не нашёл.
  • Я запускал локальный сервер со своими изменениями и всё протестировал.
  • Я добавил скриншот/видео демонстрации PR в игре, или этот PR этого не требует.

no cl

@github-actions github-actions bot added Changes: Sprites Изменение спрайтов No C# labels Aug 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

RSI Diff Bot; head commit b604abf merging into 9045fbf
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/ADT/Clothing/Back/ertleader_cyb.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/ADT/Clothing/Ears/Headsets/space_sec_headset.rsi

State Old New Status
equipped-EARS Added
icon Added

Resources/Textures/ADT/Clothing/Ears/Headsets/space_sec_headset_full.rsi

State Old New Status
equipped-EARS Added
icon Added

Resources/Textures/ADT/Clothing/Head/Hardsuits/space_sec_commander_hardsuithead.rsi

State Old New Status
equipped-HELMET Added
icon Added

Resources/Textures/ADT/Clothing/Head/Hardsuits/space_sec_officer_hardsuithead.rsi

State Old New Status
equipped-HELMET Added
icon Added

Resources/Textures/ADT/Clothing/Head/Hardsuits/space_sec_pilot_hardsuithead.rsi

State Old New Status
equipped-HELMET Added
icon Added

Resources/Textures/ADT/Clothing/Neck/space_sec_token.rsi

State Old New Status
equipped-NECK Added
icon Added

Resources/Textures/ADT/Clothing/OuterClothing/Hardsuits/space_sec_commander_hardsuit.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/ADT/Clothing/OuterClothing/Hardsuits/space_sec_officer_hardsuit.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/ADT/Clothing/OuterClothing/Hardsuits/space_sec_pilot_hardsuit.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/ADT/Clothing/Uniforms/Jumpsuit/space_sec_cadet.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/ADT/Clothing/Uniforms/Jumpsuit/space_sec_commander.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/ADT/Clothing/Uniforms/Jumpsuit/space_sec_officer.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/ADT/Clothing/Uniforms/Jumpsuit/space_sec_pilot.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/ADT/Clothing/Uniforms/Jumpsuit/space_sec_service.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/ADT/Interface/Misc/space_sec_icons.rsi

State Old New Status
ADTSpaceSecCadetStatusIcon Added
ADTSpaceSecCommanderStatusIcon Added
ADTSpaceSecOfficerStatusIcon Added
ADTSpaceSecPilotStatusIcon Added
ADTSpaceSecServiceStatusIcon Added

Resources/Textures/ADT/Mobs/Silicon/Drones/AntagDrones/drone-charger.rsi

State Old New Status
chargedrone Added
chargeshell Added
l_hand Added
r_hand Added

Resources/Textures/ADT/Mobs/Silicon/Drones/AntagDrones/drone-engineer.rsi

State Old New Status
engdrone Added
engshell Added
l_hand Added
r_hand Added

Resources/Textures/ADT/Mobs/Silicon/Drones/AntagDrones/drone-ipc-soldier.rsi

State Old New Status
ipc_full Added
ipc_icon Added

Resources/Textures/ADT/Mobs/Silicon/Drones/AntagDrones/drone-miner.rsi

State Old New Status
l_hand Added
minedrone Added
mineshell Added
r_hand Added

Resources/Textures/ADT/Objects/Misc/id_cards.rsi

State Old New Status
id-spacesec-cadet Added
id-spacesec-commander Added
id-spacesec-officer Added
id-spacesec-pilot Added
id-spacesec-service Added

Resources/Textures/ADT/Objects/Specific/drone-core-advanced.rsi

State Old New Status
drone-core-advanced Added

Resources/Textures/ADT/Objects/Specific/drone-core-basic.rsi

State Old New Status
drone-core-basic Added

Resources/Textures/ADT/Objects/Specific/drone-core-command.rsi

State Old New Status
drone-core-command Added

Resources/Textures/ADT/Objects/Specific/drone-core-elite.rsi

State Old New Status
drone-core-elite Added

Resources/Textures/ADT/Structures/Doors/Airlocks/Glass/space_sec.rsi

State Old New Status
assembly Added
bolted_open_unlit Added
bolted_unlit Added
closed Added
closed_unlit Added
closing Added
closing_unlit Added
deny_unlit Added
emergency_open_unlit Added
emergency_unlit Added
open Added
open_unlit Added
opening Added
opening_unlit Added
panel_closed Added
panel_closing Added
panel_open Added
panel_opening Added
sparks Added
sparks_broken Added
sparks_damaged Added
sparks_open Added
welded Added

Resources/Textures/ADT/Structures/Doors/Airlocks/Glass/space_sec_shuttle.rsi

State Old New Status
assembly Added
bolted_unlit Added
closed Added
closed_unlit Added
closing Added
closing_unlit Added
deny_unlit Added
emergency_unlit Added
open Added
open_unlit Added
opening Added
opening_unlit Added
panel_closing Added
panel_open Added
panel_opening Added
welded Added

Resources/Textures/ADT/Structures/Doors/Airlocks/Standard/space_sec.rsi

State Old New Status
assembly Added
bolted_open_unlit Added
bolted_unlit Added
closed Added
closed_unlit Added
closing Added
closing_unlit Added
deny_unlit Added
emergency_open_unlit Added
emergency_unlit Added
open Added
open_unlit Added
opening Added
opening_unlit Added
panel_closed Added
panel_closing Added
panel_open Added
panel_opening Added
sparks Added
sparks_broken Added
sparks_damaged Added
sparks_open Added
welded Added

Resources/Textures/ADT/Structures/Machines/space_sec_computer.rsi

State Old New Status
id Added

Resources/Textures/ADT/Structures/Wallmounts/signs.rsi

State Old New Status
poster_spacesec Added

Resources/Textures/ADT/Structures/Walls/space_sec_diagonal.rsi

State Old New Status
state0 Added
state1 Added

Resources/Textures/ADT/Structures/Walls/space_sec_wall.rsi

State Old New Status
full Added
state0 Added
state1 Added
state2 Added
state3 Added
state4 Added
state5 Added
state6 Added
state7 Added

Resources/Textures/ADT/Structures/Windows/space_sec_diagonal.rsi

State Old New Status
state0 Added
state1 Added

Resources/Textures/ADT/Structures/Windows/space_sec_window.rsi

State Old New Status
full Added
swindow0 Added
swindow1 Added
swindow2 Added
swindow3 Added
swindow4 Added
swindow5 Added
swindow6 Added
swindow7 Added

Edit: diff updated after b604abf

@1Stepka1 1Stepka1 removed their request for review August 7, 2024 17:33
@1Stepka1 1Stepka1 requested a review from Bolper August 7, 2024 17:34
Copy link
Contributor

@Bolper Bolper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resources/Prototypes/ADT/Drones/Drone-Antags/ перенести в Resources/Prototypes/ADT/Entities/Mobs/Silicons/Drones/Drone-Antags/
Resources/Prototypes/ADT/KD/Channels/Channels/DroneAntagChannel.yml перенести в Resources/Prototypes/ADT/radio_channels.yml + убрать русский язык
Resources/Prototypes/ADT/KD/Channels/keys/DroneAntagKey.yml перенести в Resources/Prototypes/ADT/Entities/Objects/Device/encryption_keys.yml + убрать русский язык
Resources/Prototypes/name_identifier_groups.yml перенести в Resources/Prototypes/ADT/name_identifier_groups.yml
Resources/Textures/ADT/Mobs/Silicon/AntagDrones/ перенести в Resources/Textures/ADT/Mobs/Silicon/Drones/AntagDrones/

Lonkuk and others added 3 commits August 7, 2024 22:27
* Добавление основных прототипов SPACE SEC

* fixes

* changes syndicate and nanotrazen fractions

* fixes_2

* Fix ai_factions.yml

* Fix Locale/ru-RU/

---------

Co-authored-by: Schrödinger <[email protected]>
@github-actions github-actions bot added the Changes: Localization Изменение локализации label Aug 7, 2024
@Lonkuk Lonkuk self-assigned this Aug 7, 2024
@Lonkuk
Copy link
Contributor Author

Lonkuk commented Aug 7, 2024

Это пиздец

Copy link
Contributor

@Bolper Bolper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Стало лучше. Не буду именно запрашивать изменния, ибо уезжаю и проверить времени скорей всего не будет.

Resources/Locale/ru-RU/ADT/access/SpaceSec.ftl Outdated Show resolved Hide resolved
Resources/Prototypes/ADT/StatusEffects/job.yml Outdated Show resolved Hide resolved
Resources/Prototypes/ADT/ai_faction.yml Outdated Show resolved Hide resolved
{
"version": 1,
"license": "CC-BY-SA-3.0",
"copyright": "Taken from CEV-Eris at commit https://github.com/discordia-space/CEV-Eris/commit/14517938186858388656a6aee14bf47af9e9649f - then modified by 20kdc & AJCM-git, glass by Peptide90, modified by brainfood1183 (github), modified by Lonkuk (github)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я в этом коммите вижу только html и yml файлы. Откуда pngшки?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Png из Resources\Textures\Structures\Doors\Airlocks\Glass\shuttle_syndicate.rsi тупо перекрашенный и мета от туда же + дописал "modified by Lonkuk (github)", где png в том коммите я без понятия

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У меня очень большое ощущение, что это и все сопутсвующие файлы должны быть в Resources/Textures/ADT/Interface/Misc/space_sec_ids.rsi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В ADT/Interface/ текстуры икон для визора, а в ADT/Objects текстуры для айди карт. Всё лежит на правильных местах.

Copy link
Contributor

github-actions bot commented Aug 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Schrodinger71
Copy link
Collaborator

Жесть тут работа кипит

@Schrodinger71 Schrodinger71 requested a review from 1Stepka1 August 10, 2024 10:42
@1Stepka1
Copy link
Collaborator

После изменений запрашиваемых от @Bolper я посмотрю что тут такое

Copy link
Collaborator

@1Stepka1 1Stepka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Изначально я думал тут будет меньше, потом больше
Но вышло нормально учитывая какой щиткод был в прошлом,есть над чем поработать

@Bolper
Copy link
Contributor

Bolper commented Aug 13, 2024

Пиздец меня Стёпка в говно опустил. Ужас

@Lonkuk
Copy link
Contributor Author

Lonkuk commented Aug 14, 2024

Всё сделано, всё переделано.

@Lonkuk Lonkuk linked an issue Aug 14, 2024 that may be closed by this pull request
@1Stepka1
Copy link
Collaborator

1Stepka1 commented Aug 15, 2024

Такс проверю все сейчас
И да если что можешь спокойно упоминать меня в дискорде

@Darkiich Darkiich dismissed 1Stepka1’s stale review August 17, 2024 17:05

исправлено

Copy link
Collaborator

@1Stepka1 1Stepka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Докрутятся тесты можешь мерджить

@Darkiich Darkiich dismissed Schrodinger71’s stale review August 17, 2024 17:24

исправлено

@Darkiich Darkiich added this pull request to the merge queue Aug 17, 2024
Merged via the queue into AdventureTimeSS14:master with commit d597a79 Aug 17, 2024
15 checks passed
github-actions bot pushed a commit to PyotrIgn/space_station_ADT that referenced this pull request Aug 18, 2024
**Проверки**
<!-- Выполнение всех следующих действий, если это приемлемо для вида
изменений сильно ускорит разбор вашего PR -->
- [x] PR полностью завершён и мне не нужна помощь чтобы его закончить.
- [x] Я внимательно просмотрел все свои изменения и багов в них не
нашёл.
- [x] Я запускал локальный сервер со своими изменениями и всё
протестировал.
- [x] Я добавил скриншот/видео демонстрации PR в игре, **или** этот PR
этого не требует.

no cl

---------

Co-authored-by: eddiedoesGIT <[email protected]>
Co-authored-by: Schrödinger <[email protected]>
Co-authored-by: Darki255 <[email protected]>
@Lonkuk Lonkuk deleted the Drone branch August 22, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Изменение локализации Changes: Sprites Изменение спрайтов No C# Status: Needs Review
Projects
None yet
6 participants